linux-kernel - Re: [PATCH v1 4/4] ACPI: platform: Keep list of ACPI IDs sorted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jtk0SBz6X3cwpKbckhGdmGE39Ynd94M5C8c4RvqVWQ=A@mail.gmail.com>
Date:   Mon, 29 Aug 2022 16:28:23 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 4/4] ACPI: platform: Keep list of ACPI IDs sorted

On Mon, Aug 29, 2022 at 4:10 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> For better maintenance keep list of the ACPI IDs sorted.
> While at it, replace terminator with more standard '{ }'.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Subject: ACPI: platform: Sort forbidden_id_list[] in ascending order

Changelog:

"For easier maintenance, sort the forbidden_id_list[] table rows in
ascending order with respect to the device ID field.

While at it, use an empty row as the list terminator, which is more
usual in the kernel."

Pretty please.

> ---
>  drivers/acpi/acpi_platform.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index 0d812fe248d4..f13409583cd9 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -20,13 +20,13 @@
>  #include "internal.h"
>
>  static const struct acpi_device_id forbidden_id_list[] = {
> +       {"ACPI0009", 0},        /* IOxAPIC */
> +       {"ACPI000A", 0},        /* IOAPIC */
>         {"PNP0000",  0},        /* PIC */
>         {"PNP0100",  0},        /* Timer */
>         {"PNP0200",  0},        /* AT DMA Controller */
> -       {"ACPI0009", 0},        /* IOxAPIC */
> -       {"ACPI000A", 0},        /* IOAPIC */
>         {"SMB0001",  0},        /* ACPI SMBUS virtual device */
> -       {"", 0},
> +       { }
>  };
>
>  static struct platform_device *acpi_platform_device_find_by_companion(struct acpi_device *adev)
> --