linux-kernel - Re: [PATCH -next 1/2] xfs: replace unnecessary seq_printf with seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2022 07:47:44 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Zeng Heng <zengheng4@...wei.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/2] xfs: replace unnecessary seq_printf with
 seq_puts

On Mon, Aug 29, 2022 at 11:42:17AM +0800, Zeng Heng wrote:
> Replace seq_printf with seq_puts when const string
> in reference, which would avoid to deal with
> unnecessary string format.
> 
> Signed-off-by: Zeng Heng <zengheng4@...wei.com>

Looks ok,
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
>  fs/xfs/xfs_stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
> index 20e0534a772c..70d38b77682b 100644
> --- a/fs/xfs/xfs_stats.c
> +++ b/fs/xfs/xfs_stats.c
> @@ -125,7 +125,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v)
>  {
>  	int j;
>  
> -	seq_printf(m, "qm");
> +	seq_puts(m, "qm");
>  	for (j = XFSSTAT_START_XQMSTAT; j < XFSSTAT_END_XQMSTAT; j++)
>  		seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j));
>  	seq_putc(m, '\n');
> -- 
> 2.25.1
>