linux-kernel - Re: [PATCH v6 0/6] LoongArch: Support toolchain with new relocation types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2022 23:02:11 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Xi Ruoyao <xry111@...111.site>
Cc:     loongarch@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>,
        WANG Xuerui <kernel@...0n.name>,
        Youling Tang <tangyouling@...ngson.cn>,
        Jinyang He <hejinyang@...ngson.cn>
Subject: Re: [PATCH v6 0/6] LoongArch: Support toolchain with new relocation types

Hi, Ruoyao,

This version looks good to me, only some small issues. Thank you very much.

Huacai

On Mon, Aug 29, 2022 at 10:57 PM Xi Ruoyao <xry111@...111.site> wrote:
>
> On Mon, 2022-08-29 at 21:31 +0800, Xi Ruoyao wrote:
>
> > Changes from v5 to v6:
> >
> > - Restore version number.
> > - Rename CONFIG_CC_HAS_EXPLICIT_RELOCS to
> > CONFIG_AS_HAS_EXPLICIT_RELOCS.
> >   It now only checks assembler.
> > - No longer support "old GCC with new Binutils", so R_LARCH_ABS* is
> >   dropped.
> >   - "Old GCC with old Binutils" is still supported until Arnd ack.
>
> >     longer support it.
> ^^^^
> This line should be removed :(.
>
> >   - "New GCC with old Binutils" is still supported as it does not
> >     require additional code.
> > - Remove "cc-option" around "-mexplicit-relocs".  For unsupported
> >   "old GCC with new Binutils" combination, forcing -mexplicit-relocs
> >   makes assembling fail, instead of silently producing unloadable
> >   modules.
> > - Move the error report for "lacking model attribute" into Makefile.
> > - Squash the two patches for R_LARCH_B26 and R_LARCH_PCALA* into one.
>
> --
> Xi Ruoyao <xry111@...111.site>
> School of Aerospace Science and Technology, Xidian University