linux-kernel - Re: [PATCH linux-next] wifi: cfg80211: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sflfc9kq.fsf@kernel.org>
Date:   Mon, 29 Aug 2022 19:12:53 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     cgel.zte@...il.com
Cc:     ajay.kathat@...rochip.com, claudiu.beznea@...rochip.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jinpeng Cui <cui.jinpeng2@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] wifi: cfg80211: remove redundant ret variable

cgel.zte@...il.com writes:

> From: Jinpeng Cui <cui.jinpeng2@....com.cn>
>
> Return value from cfg80211_rx_mgmt() directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@....com.cn>
> ---
>  drivers/net/wireless/microchip/wilc1000/cfg80211.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

The title should be:

wifi: wilc1000: remove redundant ret variable

Please read our documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches