linux-kernel - Re: [PATCH linux-next] wifi: cfg80211: remove redundant err variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ler7c9ja.fsf@kernel.org>
Date:   Mon, 29 Aug 2022 19:13:45 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     cgel.zte@...il.com
Cc:     aspriel@...il.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        johannes.berg@...el.com, a.fatoum@...gutronix.de,
        quic_vjakkam@...cinc.com, loic.poulain@...aro.org,
        hzamani.cs91@...il.com, hdegoede@...hat.com, smoch@....de,
        prestwoj@...il.com, cui.jinpeng2@....com.cn,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] wifi: cfg80211: remove redundant err variable

cgel.zte@...il.com writes:

> From: Jinpeng Cui <cui.jinpeng2@....com.cn>
>
> Return value from brcmf_fil_iovar_data_set() and
> brcmf_config_ap_mgmt_ie() directly instead of
> taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@....com.cn>
> ---
>  .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c    | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

The title should be:

wifi: brcmfmac: remove redundant err variable

Please read our documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches