linux-kernel - Re: [PATCH v2 2/2] watchdog: Enable HP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd3be720-2e7e-b390-f304-12344d65ce88@roeck-us.net>
Date:   Mon, 29 Aug 2022 09:15:45 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jerry Hoemann <jerry.hoemann@....com>, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] watchdog: Enable HP_WATCHDOG for ARM64 systems.

On 8/20/22 13:28, Jerry Hoemann wrote:
> Enable HP_WATCHDOG for ARM64 systems.
> HPWDT_NMI_DECODING requires X86 as NMI handlers are X86 specific.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9295492d24f7..cd643e50681e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1315,7 +1315,7 @@ config IT87_WDT
>   config HP_WATCHDOG
>   	tristate "HP ProLiant iLO2+ Hardware Watchdog Timer"
>   	select WATCHDOG_CORE
> -	depends on X86 && PCI
> +	depends on (ARM64 || X86) && PCI
>   	help
>   	  A software monitoring watchdog and NMI handling driver. This driver
>   	  will detect lockups and provide a stack trace. This is a driver that
> @@ -1325,7 +1325,7 @@ config HP_WATCHDOG
>   
>   config HPWDT_NMI_DECODING
>   	bool "NMI support for the HP ProLiant iLO2+ Hardware Watchdog Timer"
> -	depends on HP_WATCHDOG
> +	depends on X86 && HP_WATCHDOG
>   	default y
>   	help
>   	  Enables the NMI handler for the watchdog pretimeout NMI and the iLO