linux-kernel - Re: [PATCH] hwmon: (nct6775) Add Asus PRIME Z390-A to WMI monitoring list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6015717f-baea-7baf-e834-bb087f34819a@roeck-us.net>
Date:   Mon, 29 Aug 2022 09:25:24 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Matti Kurkela <Matti.Kurkela@....fi>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (nct6775) Add Asus PRIME Z390-A to WMI monitoring
 list

On 8/28/22 07:43, Matti Kurkela wrote:
> Asus PRIME Z390-A (and presumably other Asus Z390 motherboard versions) also requires the nct6775 chip to be accessed by the WMI method. Add it to the asus_wmi_boards list.
> 
> Tested-by: Matti Kurkela <Matti.Kurkela@....fi>
> Signed-off-by: Matti Kurkela <Matti.Kurkela@....fi>

This is your patch. You should have tested it; that is implied in Signed-off-by:.
Tested-by: is not appropriate.

> ---
> Should apply to any kernel version that includes the commit c3963bc0a0cf9ecb205a9d4976eb92b6df2fa3fd
> (hwmon: (nct6775) Split core and platform driver).

This is irrelevant; it is a functional change and will be applied
to linux-next.
> 
> --- linux-5.19.4/drivers/hwmon/nct6775-platform.c.orig  2022-08-25 12:45:54.000000000 +0300
> +++ linux-5.19.4/drivers/hwmon/nct6775-platform.c       2022-08-28 16:28:09.531738685 +0300
> @@ -1054,6 +1054,7 @@ static const char * const asus_wmi_board
>          "PRIME H410M-R",
>          "PRIME X570-P",
>          "PRIME X570-PRO",
> +       "PRIME Z390-A",

checkpatch says:

WARNING: please, no spaces at the start of a line
#77: FILE: drivers/hwmon/nct6775-platform.c:1057:
+       "PRIME Z390-A",$


Please fix.

Thanks,
Guenter

>          "ROG CROSSHAIR VIII DARK HERO",
>          "ROG CROSSHAIR VIII FORMULA",
>          "ROG CROSSHAIR VIII HERO",
> 
>