linux-kernel - Re: [PATCH v1] ACPI: property: Use acpi_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwzwkdAZwNTBQ3gh@smile.fi.intel.com>
Date:   Mon, 29 Aug 2022 20:00:01 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Linux ACPI <linux-acpi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v1] ACPI: property: Use acpi_dev_parent()

On Mon, Aug 29, 2022 at 06:12:33PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> After introducing acpi_dev_parent() in commit 62fcb99bdf10 ("ACPI: Drop
> parent field from struct acpi_device"), it is better to use it instead
> of accessing the dev.parent field in struct acpi_device directly.
> 
> Modify acpi_node_get_parent() accordingly.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks!

> Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/acpi/property.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: linux-pm/drivers/acpi/property.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/property.c
> +++ linux-pm/drivers/acpi/property.c
> @@ -1269,10 +1269,11 @@ acpi_node_get_parent(const struct fwnode
>  		return to_acpi_data_node(fwnode)->parent;
>  	}
>  	if (is_acpi_device_node(fwnode)) {
> -		struct device *dev = to_acpi_device_node(fwnode)->dev.parent;
> +		struct acpi_device *parent;
>  
> -		if (dev)
> -			return acpi_fwnode_handle(to_acpi_device(dev));
> +		parent = acpi_dev_parent(to_acpi_device_node(fwnode));
> +		if (parent)
> +			return acpi_fwnode_handle(parent);
>  	}
>  
>  	return NULL;
> 
> 
> 

-- 
With Best Regards,
Andy Shevchenko