linux-kernel - Re: [PATCH 10/31] net/tcp: Calculate TCP-AO traffic keys (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3efdb052-d95f-9093-e6db-02548dcc5126@arista.com>
Date:   Mon, 29 Aug 2022 19:22:18 +0100
From:   Dmitry Safonov <dima@...sta.com>
To:     Julia Lawall <julia.lawall@...ia.fr>, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 10/31] net/tcp: Calculate TCP-AO traffic keys (fwd)

On 8/27/22 15:31, Julia Lawall wrote:
> Please check the kfree on lie 332.

Hmm, I don't see anything criminal here, but I can do for version 2:

:--- a/net/ipv4/tcp_ao.c
:+++ b/net/ipv4/tcp_ao.c
:@@ -939,8 +939,8 @@ void tcp_ao_connect_init(struct sock *sk)
:                ao_info->snd_sne_seq = tp->write_seq;
:        } else {
:                WARN_ON_ONCE(1);
:-               kfree(tp->ao_info);
:                rcu_assign_pointer(tp->ao_info, NULL);
:+               kfree(ao_info);
:        }
: }

just to make static analyzer happy. This part of the code is anyway
under WARN_ON_ONCE(), so it's not something that actually runs (as long
as the code is consistent, it's only error-path to free memory if some
code checks become broken in future, to avoid leaks even than).

Thanks,
          Dmitry