linux-kernel - Re: [PATCH v1 1/4] iio: magnetometer: yamaha-yas530: Use pointers as driver data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yw0SFjnUwcjs/DDE@smile.fi.intel.com>
Date:   Mon, 29 Aug 2022 22:23:02 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jakob Hauser <jahau@...ketmail.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 1/4] iio: magnetometer: yamaha-yas530: Use pointers as
 driver data

On Mon, Aug 29, 2022 at 06:00:22PM +0100, Jonathan Cameron wrote:
> On Mon, 29 Aug 2022 14:24:04 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

...

> > -	yas5xx->chip_info = &yas5xx_chip_info_tbl[id->driver_data];
> > -	ci = yas5xx->chip_info;
> > +	ci = device_get_match_data(dev);
> > +	yas5xx->chip_info = ci;
> 
> Am I missing a path by which device_get_match_data() can use the i2c_device_id values?
> I'd expect to see a fallback to that if ci == NULL to cover the non firmware causes
> of probe().  I've seen a few patches without that fallback path recently so wondering
> if some magic has gotten hooked up and I've missed it (something to push that via
> a swnode perhaps?)

No, there is no such magic behind. The idea is that we use DT / ACPI overlays when
device needs to be established. But I have got your point.


-- 
With Best Regards,
Andy Shevchenko