linux-kernel - Re: [PATCH 1/2] testing/selftests: Add tests for the is_signed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208291229.31D538EA@keescook>
Date:   Mon, 29 Aug 2022 12:30:00 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Dan Williams <dan.j.williams@...el.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Ingo Molnar <mingo@...hat.com>,
        Isabella Basso <isabbasso@...eup.net>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Josh Poimboeuf <jpoimboe@...nel.org>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Sander Vanheule <sander@...nheule.net>,
        Steven Rostedt <rostedt@...dmis.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Yury Norov <yury.norov@...il.com>
Subject: Re: [PATCH 1/2] testing/selftests: Add tests for the
 is_signed_type() macro

On Fri, Aug 26, 2022 at 09:21:15AM -0700, Bart Van Assche wrote:
> Although not documented, is_signed_type() must support the 'bool' and
> pointer types next to scalar and enumeration types. Add a selftest that
> verifies that this macro handles all supported types correctly.
> 
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Isabella Basso <isabbasso@...eup.net>
> Cc: "Jason A. Donenfeld" <Jason@...c4.com>
> Cc: Josh Poimboeuf <jpoimboe@...nel.org>
> Cc: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
> Cc: Sander Vanheule <sander@...nheule.net>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Cc: Yury Norov <yury.norov@...il.com>
> Signed-off-by: Bart Van Assche <bvanassche@....org>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook