linux-kernel - Re: [PATCH linux-next] drm/amdkfd: remove redundant variables err and ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2022 15:46:49 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     cgel.zte@...il.com
Cc:     Felix.Kuehling@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...ux.ie,
        Zeal Robot <zealci@....com.cn>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        Jinpeng Cui <cui.jinpeng2@....com.cn>
Subject: Re: [PATCH linux-next] drm/amdkfd: remove redundant variables err and ret

Applied.  Thanks!

Alex

On Mon, Aug 29, 2022 at 8:29 AM <cgel.zte@...il.com> wrote:
>
> From: Jinpeng Cui <cui.jinpeng2@....com.cn>
>
> Return value from kfd_wait_on_events() and io_remap_pfn_range() directly
> instead of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@....com.cn>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 664e8b5d82c0..84da1a9ce37c 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -876,14 +876,11 @@ static int kfd_ioctl_wait_events(struct file *filp, struct kfd_process *p,
>                                 void *data)
>  {
>         struct kfd_ioctl_wait_events_args *args = data;
> -       int err;
>
> -       err = kfd_wait_on_events(p, args->num_events,
> +       return kfd_wait_on_events(p, args->num_events,
>                         (void __user *)args->events_ptr,
>                         (args->wait_for_all != 0),
>                         &args->timeout, &args->wait_result);
> -
> -       return err;
>  }
>  static int kfd_ioctl_set_scratch_backing_va(struct file *filep,
>                                         struct kfd_process *p, void *data)
> @@ -2860,7 +2857,6 @@ static int kfd_mmio_mmap(struct kfd_dev *dev, struct kfd_process *process,
>                       struct vm_area_struct *vma)
>  {
>         phys_addr_t address;
> -       int ret;
>
>         if (vma->vm_end - vma->vm_start != PAGE_SIZE)
>                 return -EINVAL;
> @@ -2880,12 +2876,11 @@ static int kfd_mmio_mmap(struct kfd_dev *dev, struct kfd_process *process,
>                  process->pasid, (unsigned long long) vma->vm_start,
>                  address, vma->vm_flags, PAGE_SIZE);
>
> -       ret = io_remap_pfn_range(vma,
> +       return io_remap_pfn_range(vma,
>                                 vma->vm_start,
>                                 address >> PAGE_SHIFT,
>                                 PAGE_SIZE,
>                                 vma->vm_page_prot);
> -       return ret;
>  }
>
>
> --
> 2.25.1
>