linux-kernel - Re: [PATCH 1/7] binder: fix alloc->vma_vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220829133452.cd4d9abe858c940126557c41@linux-foundation.org>
Date:   Mon, 29 Aug 2022 13:34:52 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Carlos Llamas <cmllamas@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        =?ISO-8859-1?Q? "Arve_?= =?ISO-8859-1?Q?Hj=F8nnev=E5g" ?= 
        <arve@...roid.com>, Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <brauner@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Liam Howlett <liam.howlett@...cle.com>,
        kernel-team@...roid.com,
        syzbot+f7dc54e5be28950ac459@...kaller.appspotmail.com,
        syzbot+a75ebe0452711c9e56d9@...kaller.appspotmail.com,
        stable@...r.kernel.org,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] binder: fix alloc->vma_vm_mm null-ptr dereference

On Mon, 29 Aug 2022 20:12:48 +0000 Carlos Llamas <cmllamas@...gle.com> wrote:

> Syzbot reported a couple issues introduced by commit 44e602b4e52f
> ("binder_alloc: add missing mmap_lock calls when using the VMA"), in
> which we attempt to acquire the mmap_lock when alloc->vma_vm_mm has not
> been initialized yet.
> 
> This can happen if a binder_proc receives a transaction without having
> previously called mmap() to setup the binder_proc->alloc space in [1].
> Also, a similar issue occurs via binder_alloc_print_pages() when we try
> to dump the debugfs binder stats file in [2].

Thanks.  I assume you'll be merging all these into mainline?

> 
> Fixes: 44e602b4e52f ("binder_alloc: add missing mmap_lock calls when using the VMA")
> Reported-by: syzbot+f7dc54e5be28950ac459@...kaller.appspotmail.com
> Reported-by: syzbot+a75ebe0452711c9e56d9@...kaller.appspotmail.com
> Cc: <stable@...r.kernel.org> # v5.15+

44e602b4e52f is only present in 6.0-rcX?