linux-kernel - Re: [PATCH v2 1/2] ARM: msm8960: Rename cxo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220829215443.dvc5xnmeqnhmxb2d@builder.lan>
Date:   Mon, 29 Aug 2022 16:54:43 -0500
From:   Bjorn Andersson <andersson@...nel.org>
To:     Rudraksha Gupta <guptarud@...il.com>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>, agross@...nel.org,
        david@...t.cz, devicetree@...r.kernel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and
 add alias

On Wed, Aug 10, 2022 at 10:51:51PM -0400, Rudraksha Gupta wrote:
> > Clock and dts patches goes through two different paths towards mainline,
> 
> > so they should be separated.
> 
> Gotcha, thanks. I will do that.
> 
> 
> > This breaks compatibility with existing DTB files.
> 
> > What you probably want is to make sure that any clocks with parent name
> 
> > of "cxo", should have a .fw_name = "cxo", then you can make a
> 
> > phandle-based reference in DT and these global names doesn't matter (and
> 
> > in the end we can remove this board_clk from the driver).
> 
> Ah, I see. If I understand correctly, it should be something like this,
> right?
> https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/gcc-msm8996.c#L169-L172

Correct, this will try to find the clock by clock-names of "cxo" and if
not found fall back to do a lookup globally just on the name "xo_board".

So it seems making .name "cxo_board" should handle both cases nicely.

Regards,
Bjorn