linux-kernel - Re: [PATCH net-next v2] drivers/net/ethernet: check return value of e1e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3668c54-b5fb-6bf5-28d3-12818d46153b@intel.com>
Date:   Mon, 29 Aug 2022 15:07:42 -0700
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Li Zhong <floridsleeves@...il.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>
CC:     <jesse.brandeburg@...el.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next v2] drivers/net/ethernet: check return value of
 e1e_rphy()

On 8/25/2022 11:56 PM, Li Zhong wrote:

nit: Could you mention the driver name in the commit title

e.g.
e1000e: check return value of e1e_rphy()

Thanks,
Tony

> e1e_rphy() could return error value, which needs to be checked and
> reported for debugging and diagnose.
> 
> Signed-off-by: Li Zhong <floridsleeves@...il.com>
> ---
>   drivers/net/ethernet/intel/e1000e/phy.c | 20 +++++++++++++++++---
>   1 file changed, 17 insertions(+), 3 deletions(-)