linux-kernel - Re: [PATCH modules-next] module: Add debugfs interface to view unloaded tainted modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bf2b4ee-fd8d-962d-0daa-9c8093ad331e@suse.com>
Date:   Mon, 29 Aug 2022 09:14:32 +0200
From:   Petr Pavlu <petr.pavlu@...e.com>
To:     Aaron Tomlin <atomlin@...hat.com>, mcgrof@...nel.org
Cc:     christophe.leroy@...roup.eu, linux-kernel@...r.kernel.org,
        linux-modules@...r.kernel.org, atomlin@...mlin.com
Subject: Re: [PATCH modules-next] module: Add debugfs interface to view
 unloaded tainted modules

On 8/23/22 21:32, Aaron Tomlin wrote:
> [...]
> @@ -59,3 +60,68 @@ void print_unloaded_tainted_modules(void)
>  		}
>  	}
>  }
> +
> +#ifdef CONFIG_DEBUG_FS
> +static void *unloaded_tainted_modules_seq_start(struct seq_file *m, loff_t *pos)
> +{
> +	mutex_lock(&module_mutex);
> +	return seq_list_start_rcu(&unloaded_tainted_modules, *pos);
> +}

unloaded_tainted_modules looks to be a proper RCU list which makes me think
this reader could use just rcu_read_lock() instead of
mutex_lock(&module_mutex)?

Thanks,
Petr