linux-kernel - Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9072e3a-2ea5-9da0-a1ba-2be67857e1ba@baylibre.com>
Date:   Mon, 29 Aug 2022 09:41:24 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Huqiang Qin <huqiang.qin@...ogic.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: meson-s4: include meson-s4-gpio.h

On 26/08/2022 13:32, Huqiang Qin wrote:
> Hi Krzysztof,
> 
> On 2022/8/25 20:02, Krzysztof Kozlowski wrote:
>> Why? We can see what you did here, but commit msg should explain why you
>> do it...
> 
> Sorry, I didn't describe this commit message clearly.
> 
> In the future, meson-s4.dtsi will have some nodes that need
> to use the meson-s4-gpio.h file.
> 
> e.g.
>      (1) Bluetooth enable pin:
>          bt_en-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
>      (2) Audio mute pin:
>          spk_mute-gpios = <&gpio GPIOH_8 GPIO_ACTIVE_LOW>;
>      (3) ...
> 
> So, this patch was born.

We understand, but since the Upstream linux codebase want to avoid dead code
as much as possible, please defer this patch when node will actually use these gpio defines.

Neil

> 
> Best regards,
> Huqiang
>