linux-kernel - Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a larger patch series)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4a25dfa-a2f9-5165-2f39-1730476c5220@linux.intel.com>
Date:   Mon, 29 Aug 2022 10:54:43 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Jiri Slaby <jirislaby@...nel.org>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a
 larger patch series)

On Mon, 29 Aug 2022, Jiri Slaby wrote:

> On 29. 08. 22, 9:41, Ilpo Järvinen wrote:> Looking into your patches, they
> also seemed to lack that> icount.tx++ thing.
> 
> Perhaps, you only overlooked it?
> 
> +	for (; (for_test) && (!tx_ready || tx_ready(port));
> +			(for_post), port->icount.tx++) {		

Ah, yes, I did (and its placement at the end of a multi-line for() didn't 
help that much either for pick it up :-)).

-- 
 i.