linux-kernel - Re: [PATCH net-next,v2] net: sched: remove redundant NULL check in change hook function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fshf78jw.fsf@toke.dk>
Date:   Mon, 29 Aug 2022 10:33:55 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     Zhengchao Shao <shaozhengchao@...wei.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        stephen@...workplumber.org
Cc:     cake@...ts.bufferbloat.net, weiyongjun1@...wei.com,
        yuehaibing@...wei.com, shaozhengchao@...wei.com
Subject: Re: [PATCH net-next,v2] net: sched: remove redundant NULL check in
 change hook function

Zhengchao Shao <shaozhengchao@...wei.com> writes:

> Currently, the change function can be called by two ways. The one way is
> that qdisc_change() will call it. Before calling change function,
> qdisc_change() ensures tca[TCA_OPTIONS] is not empty. The other way is
> that .init() will call it. The opt parameter is also checked before
> calling change function in .init(). Therefore, it's no need to check the
> input parameter opt in change function.
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

for sch_cake:

Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>