linux-kernel - Re: [PATCH] ieee802154: cc2520: add rc code in cc2520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8752aa54-28a3-9ae3-45ca-947551f31773@datenfreihafen.org>
Date:   Mon, 29 Aug 2022 10:55:31 +0200
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Li Qiong <liqiong@...china.com>,
        Varka Bhadram <varkabhadram@...il.com>,
        Alexander Aring <alex.aring@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yu Zhe <yuzhe@...china.com>
Subject: Re: [PATCH] ieee802154: cc2520: add rc code in cc2520_tx()


Hello Qiong.

On 29.08.22 09:12, Li Qiong wrote:
> The rc code is 0 at the error path "status & CC2520_STATUS_TX_UNDERFLOW".
> Assign rc code with '-EINVAL' at this error path to fix it.
> 
> Signed-off-by: Li Qiong <liqiong@...china.com>
> ---
>   drivers/net/ieee802154/cc2520.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index 1e1f40f628a0..c69b87d3837d 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -504,6 +504,7 @@ cc2520_tx(struct ieee802154_hw *hw, struct sk_buff *skb)
>   		goto err_tx;
>   
>   	if (status & CC2520_STATUS_TX_UNDERFLOW) {
> +		rc = -EINVAL;
>   		dev_err(&priv->spi->dev, "cc2520 tx underflow exception\n");
>   		goto err_tx;
>   	}

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt