linux-kernel - Re: [PATCH] usb: cdns3: fix issue with rearming ISO OUT endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220829021135.GA32228@nchen-desktop>
Date:   Mon, 29 Aug 2022 10:11:35 +0800
From:   Peter Chen <peter.chen@...nel.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     linux-usb@...r.kernel.org, gregkh@...uxfoundation.org,
        felipe.balbi@...ux.intel.com, rogerq@...nel.org,
        a-govindraju@...com, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] usb: cdns3: fix issue with rearming ISO OUT endpoint

On 22-08-25 08:21:37, Pawel Laszczak wrote:
> ISO OUT endpoint is enabled during queuing first usb request
> in transfer ring and disabled when TRBERR is reported by controller.
> After TRBERR and before next transfer added to TR driver must again
> reenable endpoint but does not.
> To solve this issue during processing TRBERR event driver must
> set the flag EP_UPDATE_EP_TRBADDR in priv_ep->flags field.
> 
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> cc: <stable@...r.kernel.org>
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>

Acked-by: Peter Chen <peter.chen@...nel.org>

> ---
>  drivers/usb/cdns3/cdns3-gadget.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index 682ceba25765..fa8263951e63 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -1689,6 +1689,7 @@ static int cdns3_check_ep_interrupt_proceed(struct cdns3_endpoint *priv_ep)
>  				ep_cfg &= ~EP_CFG_ENABLE;
>  				writel(ep_cfg, &priv_dev->regs->ep_cfg);
>  				priv_ep->flags &= ~EP_QUIRK_ISO_OUT_EN;
> +				priv_ep->flags |= EP_UPDATE_EP_TRBADDR;
>  			}
>  			cdns3_transfer_completed(priv_dev, priv_ep);
>  		} else if (!(priv_ep->flags & EP_STALLED) &&
> -- 
> 2.25.1
> 

-- 

Thanks,
Peter Chen