linux-kernel - [PATCH] ACPI: Skip IRQ override on Asus Vivobook K3402ZA/K3502ZA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 28 Aug 2022 23:04:19 -0400
From:   Tamim Khan <tamim@...etak.com>
To:     linux-acpi@...r.kernel.org
Cc:     lenb@...nel.org, rafael@...nel.org, linux-kernel@...r.kernel.org,
        Tamim Khan <tamim@...etak.com>,
        Hui Wang <hui.wang@...onical.com>,
        Sunand <sunandchakradhar@...il.com>
Subject: [PATCH] ACPI: Skip IRQ override on Asus Vivobook K3402ZA/K3502ZA

In the ACPI DSDT table for Asus VivoBook K3402ZA/K3502ZA
IRQ 1 is described as ActiveLow; however, the kernel overrides
it to Edge_High. This prevents the internal keyboard from working
on these laptops. In order to fix this add these laptops to the
skip_override_table so that the kernel does not override IRQ 1 to
Edge_High.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=216158
Reviewed-by: Hui Wang <hui.wang@...onical.com>
Tested-by: Tamim Khan <tamim@...etak.com>
Tested-by: Sunand <sunandchakradhar@...il.com>
Signed-off-by: Tamim Khan <tamim@...etak.com>
---
This patch is very similar to the fix implemented for keyboards on 
Medion laptops in 892a012699fc0b91a2ed6309078936191447f480 
(ACPI: resources: Add DMI-based legacy IRQ override quirk) and 
1b26ae40092b43bb6e9c5df376227382b390b953 (ACPI: resources: Add one 
more Medion model in IRQ override quirk) and has been reviewed by the
author of those commits. It has also been tested by myself on a K3502ZA 
and by someone else with a K3402ZA to verify that this patch allows
the internal keyboard to work.

 drivers/acpi/resource.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 510cdec375c4..2ebc85233bac 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -399,6 +399,24 @@ static const struct dmi_system_id medion_laptop[] = {
 	{ }
 };
 
+static const struct dmi_system_id asus_laptop[] = {
+	{
+		.ident = "Asus Vivobook K3402ZA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "K3402ZA"),
+		},
+	},
+	{
+		.ident = "Asus Vivobook K3502ZA",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "K3502ZA"),
+		},
+	},
+	{ }
+};
+
 struct irq_override_cmp {
 	const struct dmi_system_id *system;
 	unsigned char irq;
@@ -409,6 +427,7 @@ struct irq_override_cmp {
 
 static const struct irq_override_cmp skip_override_table[] = {
 	{ medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0 },
+	{ asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0 },
 };
 
 static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
-- 
2.37.2