linux-kernel - RE: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM5PR12MB162825333C0ED3A87D886165AD769@DM5PR12MB1628.namprd12.prod.outlook.com>
Date:   Mon, 29 Aug 2022 11:44:23 +0000
From:   Sandipan Patra <spatra@...dia.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Bibek Basu <bbasu@...dia.com>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>
Subject: RE: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson Orin



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Friday, August 26, 2022 11:05 PM
> To: Sandipan Patra <spatra@...dia.com>; thierry.reding@...il.com;
> Jonathan Hunter <jonathanh@...dia.com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; devicetree@...r.kernel.org; linux-
> tegra@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Bibek Basu <bbasu@...dia.com>; Krishna Yarlagadda
> <kyarlagadda@...dia.com>
> Subject: Re: [PATCH 2/2] arm64: tegra: Add user PWM support on Jetson
> Orin
> 
> External email: Use caution opening links or attachments
> 
> 
> On 26/08/2022 15:17, Sandipan Patra wrote:
> > Enable in device tree and use it to drive the PWM controllers on
> > 40 pin header of Orin dev-kit.
> >
> > Signed-off-by: Sandipan Patra <spatra@...dia.com>
> > ---
> >  .../arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > index a85993c85e45..e76894574d32 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> > @@ -2,4 +2,18 @@
> >
> >  / {
> >       compatible = "nvidia,p3737-0000";
> > +
> > +     bus@0 {
> > +             pwm@...0000 {
> > +                     status = "okay";
> > +             };
> 
> Overriding by node path is error-prone. You should override by label.
ACK.

Thanks & Regards,
Sandipan

> 
> Best regards,
> Krzysztof