linux-kernel - Re: [PATCH] wifi: cfg80211: add error code in brcmf_notify_sched_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2022 19:31:25 +0800
From:   liqiong <liqiong@...china.com>
To:     Arend Van Spriel <aspriel@...il.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yu Zhe <yuzhe@...china.com>
Subject: Re: [PATCH] wifi: cfg80211: add error code in
 brcmf_notify_sched_scan_results()



在 2022年08月29日 16:51, Arend Van Spriel 写道:
> On 8/29/2022 8:58 AM, Li Qiong wrote:
>> The err code is 0 at the first two "out_err" paths, add error code
>> '-EINVAL' for these error paths.
>
> There is no added value provided in this change. There is an error message, but it is otherwise silently ignored as there is no additional fault handling required.
It should be better to fix the return code, and It seems that the code has been checked, eg:
if (ifp->drvr->fweh.evt_handler[i]) {
.....
}


>
> Regards,
> Arend
>
>> Signed-off-by: Li Qiong <liqiong@...china.com>
>> ---
>>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 ++
>>   1 file changed, 2 insertions(+)