linux-kernel - Re: [PATCH 4/4] spi: mt7621: Remove 'clk' from 'struct mt7621

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8c87417-f37e-7c7a-a4a4-c5a01118e7a8@gmail.com>
Date:   Mon, 29 Aug 2022 13:18:37 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        broonie@...nel.org, gregkh@...uxfoundation.org, neil@...wn.name,
        blogic@...nwrt.org
Cc:     linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 4/4] spi: mt7621: Remove 'clk' from 'struct mt7621_spi'



On 27/08/2022 13:42, Christophe JAILLET wrote:
> The 'clk' field in 'struct mt7621_spi' is useless, remove it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

IMHO should be part of patch 2/4.

Regards,
Matthias

> ---
>   drivers/spi/spi-mt7621.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-mt7621.c b/drivers/spi/spi-mt7621.c
> index 114f98dcae5e..c4cc8e2f85e2 100644
> --- a/drivers/spi/spi-mt7621.c
> +++ b/drivers/spi/spi-mt7621.c
> @@ -55,7 +55,6 @@ struct mt7621_spi {
>   	void __iomem		*base;
>   	unsigned int		sys_freq;
>   	unsigned int		speed;
> -	struct clk		*clk;
>   	int			pending_write;
>   };
>   
> @@ -361,9 +360,8 @@ static int mt7621_spi_probe(struct platform_device *pdev)
>   
>   	rs = spi_controller_get_devdata(master);
>   	rs->base = base;
> -	rs->clk = clk;
>   	rs->master = master;
> -	rs->sys_freq = clk_get_rate(rs->clk);
> +	rs->sys_freq = clk_get_rate(clk);
>   	rs->pending_write = 0;
>   	dev_info(&pdev->dev, "sys_freq: %u\n", rs->sys_freq);
>