linux-kernel - Re: [PATCH v7 2/3] thunderbolt: Modify tb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a514ace3-ee63-7556-1b89-cd76e6333015@amd.com>
Date:   Mon, 29 Aug 2022 07:23:04 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     Szuying Chen <chensiying21@...il.com>, gregkh@...uxfoundation.org,
        mika.westerberg@...ux.intel.com, andreas.noever@...il.com,
        michael.jamet@...el.com, YehezkelShB@...il.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Yd_Tseng@...edia.com.tw, Chloe_Chen@...edia.com.tw,
        Richard_Hsu@...edia.com.tw
Subject: Re: [PATCH v7 2/3] thunderbolt: Modify tb_nvm major and minor size.

On 8/29/22 06:10, Szuying Chen wrote:
> From: Szuying Chen <Chloe_Chen@...edia.com.tw>
> 
> The patch modify tb_nvm->major and tb_nvm->minor size to u32 that support
> diffrent vendor's NVM version show.

s/diffrent/different/

I would suggest you explain the WHY of this patch.  I would have worded 
it something like this:

Intel's version can be stored in 2 bytes, but ASMedia's version requires 
8 bytes.  Extend the 'major' and 'minor' members of the tb_nvm structure 
to support both vendors.

> 
> Signed-off-by: Szuying Chen <Chloe_Chen@...edia.com.tw>
> ---
> Modify tb_nvm->major and tb_nvm->minor size to u32.

The idea with the changelog below the cutline is supposed to help 
reviewers know what to focus on when reviewing from one patch to another.

In general it's best to specify what changed from which patch to which 
past the cut line.

For example if this was first patch version that introduced the change 
it should be something like:

v6->v7:
  * New patch based on suggestion by Mario


> 
>   drivers/thunderbolt/tb.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thunderbolt/tb.h b/drivers/thunderbolt/tb.h
> index fc32737fcde4..9cf62d5f25d2 100644
> --- a/drivers/thunderbolt/tb.h
> +++ b/drivers/thunderbolt/tb.h
> @@ -50,8 +50,8 @@
>    */
>   struct tb_nvm {
>   	struct device *dev;
> -	u8 major;
> -	u8 minor;
> +	u32 major;
> +	u32 minor;
>   	int id;
>   	struct nvmem_device *active;
>   	struct nvmem_device *non_active;
> --
> 2.34.1
>