linux-kernel - RE: [PATCH v3 14/14] iio: hmc425a: simplify using devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN4PR03MB678490A2B25A8B2E38EA99B399799@SN4PR03MB6784.namprd03.prod.outlook.com>
Date:   Tue, 30 Aug 2022 13:55:38 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Matti Vaittinen <mazziesaccount@...il.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
CC:     Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 14/14] iio: hmc425a: simplify using
 devm_regulator_get_enable()



> -----Original Message-----
> From: Matti Vaittinen <mazziesaccount@...il.com>
> Sent: Tuesday, August 30, 2022 3:00 PM
> To: Sa, Nuno <Nuno.Sa@...log.com>; Matti Vaittinen
> <matti.vaittinen@...rohmeurope.com>
> Cc: Lars-Peter Clausen <lars@...afoo.de>; Hennerich, Michael
> <Michael.Hennerich@...log.com>; Jonathan Cameron
> <jic23@...nel.org>; linux-iio@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v3 14/14] iio: hmc425a: simplify using
> devm_regulator_get_enable()
> 
> [External]
> 
> On 8/30/22 14:49, Sa, Nuno wrote:
> >
> >> From: Matti Vaittinen <mazziesaccount@...il.com>
> >> Sent: Friday, August 19, 2022 9:21 PM
> >> To: Matti Vaittinen <mazziesaccount@...il.com>; Matti Vaittinen
> >> <matti.vaittinen@...rohmeurope.com>
> >> Cc: Lars-Peter Clausen <lars@...afoo.de>; Hennerich, Michael
> >> <Michael.Hennerich@...log.com>; Jonathan Cameron
> >> <jic23@...nel.org>; linux-iio@...r.kernel.org; linux-
> >> kernel@...r.kernel.org
> >> Subject: [PATCH v3 14/14] iio: hmc425a: simplify using
> >> devm_regulator_get_enable()
> >>
> >> [External]
> >>
> >> Drop open-coded pattern: 'devm_regulator_get(),
> regulator_enable(),
> >> add_action_or_reset(regulator_disable)' and use the
> >> devm_regulator_get_enable() and drop the pointer to the
> regulator.
> >> This simplifies code and makes it less tempting to add manual
> control
> >> for the regulator which is also controlled by devm.
> >>
> >> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> >>
> >> ---
> >
> > Acked-by: Nuno Sá <nuno.sa@...log.com>
> >
> > (I see that in this patch you are not using dev_err_probe(). Maybe
> some
> > consistency in the series and where applicable would be appropriate
> :))
> 
> I don't think the driver did originally print an error if regulator get
> or enable failed. I didn't want to add any new prints - just converted
> the existing ones to use dev_err_probe(). I believe adding new prints
> would've been somewhat unrelated change :)
> 

Ahh that makes sense. I failed to see the print that you were replacing
in the ad7606 patch...

- Nuno Sá