linux-kernel - Re: [PATCH] random: use raw spinlocks for use on RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yw4rsdA7xu4+UrLi@zx2c4.com>
Date:   Tue, 30 Aug 2022 11:24:33 -0400
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH] random: use raw spinlocks for use on RT

Hi Sebastian,

On Tue, Aug 30, 2022 at 12:13:44PM +0200, Sebastian Andrzej Siewior wrote:
> The first patch did so yes. The second simply retried in two secs and
> this shouldn't be problematic.

This seemed pretty bad too, because now you potentially miss up to 2
seconds of messages AND it adds more complexity.

I'm fine with changing things up to accommodate RT, but not when the
result is so obviously worse than before.

In my tests I can't see any latency difference with using raw spinlocks
in random.c. Maybe I'm doing things wrong? But I'm not seeing anything
change...

Jason