linux-kernel - Re: [PATCH 1/2] mm: memcontrol: remove mem_cgroup_kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202208310147.Vog4y88J-lkp@intel.com>
Date:   Wed, 31 Aug 2022 02:03:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kairui Song <ryncsn@...il.com>, cgroups@...r.kernel.org,
        linux-mm@...ck.org
Cc:     kbuild-all@...ts.01.org, Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Shakeel Butt <shakeelb@...gle.com>,
        Muchun Song <songmuchun@...edance.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org, Kairui Song <kasong@...cent.com>
Subject: Re: [PATCH 1/2] mm: memcontrol: remove mem_cgroup_kmem_disabled

Hi Kairui,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-memcontrol-cleanup-and-optimize-for-accounting-params/20220830-140150
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: x86_64-randconfig-a004
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/45d0812323db1fbf1751cbd9d112f72f151ca3c6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kairui-Song/mm-memcontrol-cleanup-and-optimize-for-accounting-params/20220830-140150
        git checkout 45d0812323db1fbf1751cbd9d112f72f151ca3c6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/static_key.h:1,
                    from arch/x86/include/asm/nospec-branch.h:6,
                    from arch/x86/include/asm/irqflags.h:9,
                    from include/linux/irqflags.h:16,
                    from include/linux/rcupdate.h:26,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/cgroup.h:12,
                    from include/linux/memcontrol.h:13,
                    from mm/memcontrol.c:29:
   mm/memcontrol.c: In function 'cgroup_memory':
>> mm/memcontrol.c:7182:39: error: 'memcg_kmem_enabled_key' undeclared (first use in this function); did you mean 'memcg_kmem_enabled'?
    7182 |                 static_branch_enable(&memcg_kmem_enabled_key);
         |                                       ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:517:69: note: in definition of macro 'static_branch_enable'
     517 | #define static_branch_enable(x)                 static_key_enable(&(x)->key)
         |                                                                     ^
   mm/memcontrol.c:7182:39: note: each undeclared identifier is reported only once for each function it appears in
    7182 |                 static_branch_enable(&memcg_kmem_enabled_key);
         |                                       ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/jump_label.h:517:69: note: in definition of macro 'static_branch_enable'
     517 | #define static_branch_enable(x)                 static_key_enable(&(x)->key)
         |                                                                     ^


vim +7182 mm/memcontrol.c

  7167	
  7168	static int __init cgroup_memory(char *s)
  7169	{
  7170		char *token;
  7171	
  7172		while ((token = strsep(&s, ",")) != NULL) {
  7173			if (!*token)
  7174				continue;
  7175			if (!strcmp(token, "nosocket"))
  7176				cgroup_memory_nosocket = true;
  7177			if (!strcmp(token, "nokmem"))
  7178				cgroup_memory_nokmem = true;
  7179		}
  7180	
  7181		if (!cgroup_memory_nokmem)
> 7182			static_branch_enable(&memcg_kmem_enabled_key);
  7183	
  7184		return 1;
  7185	}
  7186	__setup("cgroup.memory=", cgroup_memory);
  7187	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (136207 bytes)