linux-kernel - Re: [PATCH] f2fs: fix to disallow getting inner inode via f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208310225.2ZPFsWDO-lkp@intel.com>
Date:   Wed, 31 Aug 2022 02:44:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>,
        jaegeuk@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>,
        Chao Yu <chao@...nel.org>
Subject: Re: [PATCH] f2fs: fix to disallow getting inner inode via f2fs_iget()

Hi Chao,

I love your patch! Yet something to improve:

[auto build test ERROR on jaegeuk-f2fs/dev-test]
[also build test ERROR on linus/master v6.0-rc3 next-20220830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chao-Yu/f2fs-fix-to-disallow-getting-inner-inode-via-f2fs_iget/20220830-183707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: hexagon-randconfig-r041-20220830
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c7df82e4693c19e3fd2e25c83eb04d9deb7b7b59)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/5a56a97af05aaf2c2ca14d0fd9f7385b42dca0a2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Chao-Yu/f2fs-fix-to-disallow-getting-inner-inode-via-f2fs_iget/20220830-183707
        git checkout 5a56a97af05aaf2c2ca14d0fd9f7385b42dca0a2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/f2fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> fs/f2fs/inode.c:577:10: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'struct inode *' [-Wint-conversion]
                   return -EINVAL;
                          ^~~~~~~
   1 error generated.


vim +577 fs/f2fs/inode.c

   573	
   574	struct inode *f2fs_iget(struct super_block *sb, unsigned long ino)
   575	{
   576		if (f2fs_check_nid_range(F2FS_SB(sb), ino))
 > 577			return -EINVAL;
   578	
   579		return f2fs_iget_inner(sb, ino);
   580	}
   581	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (113017 bytes)