linux-kernel - Re: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 20:11:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver

On Fri, Aug 26, 2022 at 02:43:38PM +0000, Wei Yongjun wrote:

> @@ -0,0 +1,221 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * SPI controller Testing Driver
> + *
> + * Copyright(c) 2022 Huawei Technologies Co., Ltd.
> + */

Please make the entire comment a C++ one so things look more
intentional.

> +	master = spi_alloc_master(&pdev->dev, sizeof(struct mockup_spi));
> +	if (!master) {
> +		pr_err("failed to alloc spi master\n");
> +		return -ENOMEM;
> +	}

Please use the new _controller() API, we're trying to remove the
use of outdated terminology.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)