linux-kernel - Re: [PATCH linux-next] drm/amdgpu: Remove the unneeded result variable 'r'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 15:56:05 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     cgel.zte@...il.com
Cc:     alexander.deucher@....com, Jack.Xiao@....com, tao.zhou1@....com,
        airlied@...ux.ie, ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>, Xinhui.Pan@....com,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        rajib.mahapatra@....com, YiPeng.Chai@....com,
        dri-devel@...ts.freedesktop.org, christian.koenig@....com,
        Hawking.Zhang@....com
Subject: Re: [PATCH linux-next] drm/amdgpu: Remove the unneeded result
 variable 'r'

Applied.  Thanks!

Alex

On Tue, Aug 30, 2022 at 4:32 AM <cgel.zte@...il.com> wrote:
>
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Return the value sdma_v4_0_start() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 65181efba50e..0cf9d3b486b2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2002,7 +2002,6 @@ static int sdma_v4_0_sw_fini(void *handle)
>
>  static int sdma_v4_0_hw_init(void *handle)
>  {
> -       int r;
>         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
>         if (adev->flags & AMD_IS_APU)
> @@ -2011,9 +2010,7 @@ static int sdma_v4_0_hw_init(void *handle)
>         if (!amdgpu_sriov_vf(adev))
>                 sdma_v4_0_init_golden_registers(adev);
>
> -       r = sdma_v4_0_start(adev);
> -
> -       return r;
> +       return sdma_v4_0_start(adev);
>  }
>
>  static int sdma_v4_0_hw_fini(void *handle)
> --
> 2.25.1