linux-kernel - Re: [PATCH] selinux: use int arrays for boolean values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTe92h-FR0GOepVrPqWwOgKLPV6NcXxi4sRpAjEbPkt5w@mail.gmail.com>
Date:   Tue, 30 Aug 2022 17:04:38 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Christian Göttsche <cgzones@...glemail.com>
Cc:     selinux@...r.kernel.org,
        Stephen Smalley <stephen.smalley.work@...il.com>,
        Eric Paris <eparis@...isplace.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selinux: use int arrays for boolean values

On Tue, Aug 30, 2022 at 11:45 AM Christian Göttsche
<cgzones@...glemail.com> wrote:
>
> Do not cast pointers of signed integers to pointers of unsigned integers
> and vice versa.
>
> It should currently not be an issue since they hold SELinux boolean
> values which should only contain either 0's or 1's, which should have
> the same representation.
>
> Reported by sparse:
>
>     security/selinux/selinuxfs.c:1485:30: warning: incorrect type in assignment (different signedness)
>     security/selinux/selinuxfs.c:1485:30:    expected unsigned int *
>     security/selinux/selinuxfs.c:1485:30:    got int *[addressable] values
>     security/selinux/selinuxfs.c:1402:48: warning: incorrect type in argument 3 (different signedness)
>     security/selinux/selinuxfs.c:1402:48:    expected int *values
>     security/selinux/selinuxfs.c:1402:48:    got unsigned int *bool_pending_values
>
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> ---
> Previous patch proposal: https://patchwork.kernel.org/project/selinux/patch/20220502135907.31035-1-cgzones@googlemail.com/
> ---
>  security/selinux/selinuxfs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Merged into selinux/next, thanks!

-- 
paul-moore.com