linux-kernel - Re: [PATCH] audit: remove obvious unnecessary header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202208310505.EyxcPqGV-lkp@intel.com>
Date:   Wed, 31 Aug 2022 05:17:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     wuchi <wuchi.zero@...il.com>, paul@...l-moore.com,
        eparis@...hat.com
Cc:     kbuild-all@...ts.01.org, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: remove obvious unnecessary header files

Hi wuchi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pcmoore-audit/next]
[also build test ERROR on linus/master v6.0-rc3 next-20220830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/wuchi/audit-remove-obvious-unnecessary-header-files/20220830-185249
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: sh-randconfig-m041-20220830 (https://download.01.org/0day-ci/archive/20220831/202208310505.EyxcPqGV-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f693f8ef00782656e1a94129e11611d410914905
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review wuchi/audit-remove-obvious-unnecessary-header-files/20220830-185249
        git checkout f693f8ef00782656e1a94129e11611d410914905
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/sched/signal.h:14,
                    from include/linux/rcuwait.h:6,
                    from include/linux/percpu-rwsem.h:7,
                    from include/linux/fs.h:33,
                    from kernel/auditsc.c:36:
   kernel/auditsc.c: In function 'audit_seccomp':
>> arch/sh/include/asm/ptrace.h:127:30: error: implicit declaration of function 'task_stack_page'; did you mean 'task_stack_vm_area'? [-Werror=implicit-function-declaration]
     127 |         ((struct pt_regs *) (task_stack_page(task) + THREAD_SIZE) - 1)
         |                              ^~~~~~~~~~~~~~~
   arch/sh/include/asm/processor_32.h:185:25: note: in expansion of macro 'task_pt_regs'
     185 | #define KSTK_EIP(tsk)  (task_pt_regs(tsk)->pc)
         |                         ^~~~~~~~~~~~
   kernel/auditsc.c:2987:47: note: in expansion of macro 'KSTK_EIP'
    2987 |                          in_compat_syscall(), KSTK_EIP(current), code);
         |                                               ^~~~~~~~
   cc1: some warnings being treated as errors


vim +127 arch/sh/include/asm/ptrace.h

34d0b5af50a063 arch/sh/include/asm/ptrace.h Paul Mundt     2009-12-28  122  
c84b51e65ea2f2 arch/sh/include/asm/ptrace.h Paul Gortmaker 2011-07-31  123  extern void ptrace_triggered(struct perf_event *bp,
34d0b5af50a063 arch/sh/include/asm/ptrace.h Paul Mundt     2009-12-28  124  		      struct perf_sample_data *data, struct pt_regs *regs);
34d0b5af50a063 arch/sh/include/asm/ptrace.h Paul Mundt     2009-12-28  125  
3cf0f4ece9f168 include/asm-sh/ptrace.h      Al Viro        2006-01-12  126  #define task_pt_regs(task) \
4f099ebb27211d arch/sh/include/asm/ptrace.h Magnus Damm    2009-02-23 @127  	((struct pt_regs *) (task_stack_page(task) + THREAD_SIZE) - 1)
3cf0f4ece9f168 include/asm-sh/ptrace.h      Al Viro        2006-01-12  128  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp