linux-kernel - Re: [PATCH AUTOSEL 5.19 01/33] firmware: dmi: Use the proper accessor for the version field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220830233237.0c08cc7e@endymion.delvare>
Date:   Tue, 30 Aug 2022 23:32:37 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH AUTOSEL 5.19 01/33] firmware: dmi: Use the proper
 accessor for the version field

Hi Sasha,

On Tue, 30 Aug 2022 13:17:52 -0400, Sasha Levin wrote:
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> [ Upstream commit d2139dfca361a1f5bfc4d4a23455b1a409a69cd4 ]
> 
> The byte at offset 6 represents length. Don't take it and drop it
> immediately by using proper accessor, i.e. get_unaligned_be24().
> 
> [JD: Change the subject to something less frightening]

Nack. This is NOT a bug fix, there's simply no reason to backport
this to stable kernel trees.

Thanks,
-- 
Jean Delvare
SUSE L3 Support