linux-kernel - Re: [PATCH -next] fs/hfsplus: Fix some kernel-doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74683697-df9f-6f8f-00eb-4bb25e1a1638@infradead.org>
Date:   Tue, 30 Aug 2022 16:58:45 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>, axboe@...nel.dk
Cc:     hch@....de, bvanassche@....org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] fs/hfsplus: Fix some kernel-doc comments



On 8/30/22 00:42, Yang Li wrote:
> Add the description of @opf and remove @op and @op_flags in
> hfsplus_submit_bio() kernel-doc comment.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2013
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>


Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  fs/hfsplus/wrapper.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
> index 0b791adf02e5..6202e877f459 100644
> --- a/fs/hfsplus/wrapper.c
> +++ b/fs/hfsplus/wrapper.c
> @@ -30,8 +30,7 @@ struct hfsplus_wd {
>   * @sector: block to read or write, for blocks of HFSPLUS_SECTOR_SIZE bytes
>   * @buf: buffer for I/O
>   * @data: output pointer for location of requested data
> - * @op: direction of I/O
> - * @op_flags: request op flags
> + * @opf: operation and flags for bio
>   *
>   * The unit of I/O is hfsplus_min_io_size(sb), which may be bigger than
>   * HFSPLUS_SECTOR_SIZE, and @buf must be sized accordingly. On reads

-- 
~Randy