linux-kernel - RE: [PATCH 3/4] bindings: firmware: Update binding doc for the zynqmp afi config node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB3993B4525E7B5D00AFFC3565CD799@DM6PR12MB3993.namprd12.prod.outlook.com>
Date:   Tue, 30 Aug 2022 05:41:08 +0000
From:   "Manne, Nava kishore" <nava.kishore.manne@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "git (AMD-Xilinx)" <git@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "hao.wu@...el.com" <hao.wu@...el.com>,
        "yilun.xu@...el.com" <yilun.xu@...el.com>,
        "trix@...hat.com" <trix@...hat.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "ronak.jain@...inx.com" <ronak.jain@...inx.com>,
        "rajan.vaja@...inx.com" <rajan.vaja@...inx.com>,
        "abhyuday.godhasara@...inx.com" <abhyuday.godhasara@...inx.com>,
        "piyush.mehta@...inx.com" <piyush.mehta@...inx.com>,
        "lakshmi.sai.krishna.potthuri@...inx.com" 
        <lakshmi.sai.krishna.potthuri@...inx.com>,
        "harsha.harsha@...inx.com" <harsha.harsha@...inx.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "nava.manne@...inx.com" <nava.manne@...inx.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>
Subject: RE: [PATCH 3/4] bindings: firmware: Update binding doc for the zynqmp
 afi config node

Hi Krzysztof,

	Please find my response inline. 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, August 24, 2022 6:28 PM
> To: Manne, Nava kishore <nava.kishore.manne@....com>; git (AMD-Xilinx)
> <git@....com>; robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> michal.simek@...inx.com; mdf@...nel.org; hao.wu@...el.com;
> yilun.xu@...el.com; trix@...hat.com; p.zabel@...gutronix.de;
> gregkh@...uxfoundation.org; ronak.jain@...inx.com; rajan.vaja@...inx.com;
> abhyuday.godhasara@...inx.com; piyush.mehta@...inx.com;
> lakshmi.sai.krishna.potthuri@...inx.com; harsha.harsha@...inx.com;
> linus.walleij@...aro.org; nava.manne@...inx.com;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; linux-fpga@...r.kernel.org
> Subject: Re: [PATCH 3/4] bindings: firmware: Update binding doc for the
> zynqmp afi config node
> 
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
> 
> "bindings" is no correct.

Will fix in v2.

> 
> On 24/08/2022 06:55, Nava kishore Manne wrote:
> > Updates binding document for the zynqmp afi config node to handle the
> > PS_PL Bus-width and resets.
> 
> Use imperative language:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/sub
> mitting-patches.rst#L95

Will fix in v2.

> >
> > Signed-off-by: Nava kishore Manne <nava.kishore.manne@....com>
> > ---
> >  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml     | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml
> > b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml index f14f7b454f07..9504665cad95 100644
> > ---
> > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-fi
> > +++ rmware.yaml
> > @@ -59,6 +59,13 @@ properties:
> >        controller.
> >      type: object
> >
> > +  zynqmp-fpga:
> 
> Just: fpga
> 
 
Will fix in v2.

Regards,
Navakishore.