linux-kernel - Re: [PATCH v2 5/6] tty: n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d8d0d72-a5b7-724e-a70a-71d9fd3330c4@kernel.org>
Date:   Tue, 30 Aug 2022 09:00:41 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     "D. Starke" <daniel.starke@...mens.com>,
        linux-serial@...r.kernel.org, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] tty: n_gsm: name the debug bits

On 23. 08. 22, 8:22, D. Starke wrote:
> From: Daniel Starke <daniel.starke@...mens.com>
> 
> Introduce defines to name the various debug bits used within the code to
> improve readability and to make its specific use clear.
> 
> Signed-off-by: Daniel Starke <daniel.starke@...mens.com>
> ---
>   drivers/tty/n_gsm.c | 31 +++++++++++++++++++------------
>   1 file changed, 19 insertions(+), 12 deletions(-)
> 
> No changes since v1.
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 5a20561c0a5d..fcf2d52d5095 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -63,6 +63,13 @@
>   static int debug;
>   module_param(debug, int, 0600);
>   
> +/* Module debug bits */
> +#define DBG_DUMP	(1 << 0) /* Data transmission dump. */
> +#define DBG_CD_ON	(1 << 1) /* Always assume CD line on. */
> +#define DBG_DATA	(1 << 2) /* Data transmission details. */
> +#define DBG_ERRORS	(1 << 3) /* Details for fail conditions. */
> +#define DBG_TTY		(1 << 4) /* Transmission statistics for DLCI TTYs. */

Could you use BIT() instead?

thanks,
-- 
js
suse labs