linux-kernel - Re: [PATCH] phy: tegra: xusb: check the return value of devm_kzalloc() in tegra_xusb_setup_usb_role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yw26FXFyb3GwQaux@matsya>
Date:   Tue, 30 Aug 2022 12:49:49 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     williamsukatube@....com
Cc:     linux-phy@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, jckuo@...dia.com, kishon@...com,
        thierry.reding@...il.com, jonathanh@...dia.com,
        William Dean <williamsukatube@...il.com>,
        Hacash Robot <hacashRobot@...tino.com>
Subject: Re: [PATCH] phy: tegra: xusb: check the return value of
 devm_kzalloc() in tegra_xusb_setup_usb_role_switch()

On 23-07-22, 11:41, williamsukatube@....com wrote:
> From: William Dean <williamsukatube@...il.com>
> 
> The function devm_kzalloc() in tegra_xusb_setup_usb_role_switch()
> can fail, so its return value should be checked.
> 
> Fixes: f67213cee2b35 ("phy: tegra: xusb: Add usb-role-switch support")
> Reported-by: Hacash Robot <hacashRobot@...tino.com>

Where is this bug report?

> Signed-off-by: William Dean <williamsukatube@...il.com>
> ---
>  drivers/phy/tegra/xusb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index aa5237eacd29..e3611fb4c779 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -668,6 +668,8 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>  	port->dev.driver = devm_kzalloc(&port->dev,
>  					sizeof(struct device_driver),
>  					GFP_KERNEL);
> +	if (!port->dev.driver)
> +		return -ENOMEM;
>  	port->dev.driver->owner	 = THIS_MODULE;
>  
>  	port->usb_role_sw = usb_role_switch_register(&port->dev,
> -- 
> 2.25.1

-- 
~Vinod