linux-kernel - Re: [PATCH 2/3] openrisc: ptrace: Remove duplicate operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 07:33:51 +0000
From:   Stafford Horne <shorne@...il.com>
To:     guoren@...nel.org
Cc:     oleg@...hat.com, vgupta@...nel.org, linux@...linux.org.uk,
        monstr@...str.eu, dinguyen@...nel.org, palmer@...belt.com,
        davem@...emloft.net, arnd@...db.de, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-snps-arc@...ts.infradead.org, sparclinux@...r.kernel.org,
        openrisc@...ts.librecores.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH 2/3] openrisc: ptrace: Remove duplicate operation

On Tue, Aug 30, 2022 at 02:53:15AM -0400, guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> The TIF_SYSCALL_TRACE is controlled by a common code, see
> kernel/ptrace.c and include/linux/thread.h.
> 
> clear_task_syscall_work(child, SYSCALL_TRACE);
> 
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@...nel.org>

Acked-by: Stafford Horne <shorne@...il.com>

> ---
>  arch/openrisc/kernel/ptrace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/openrisc/kernel/ptrace.c b/arch/openrisc/kernel/ptrace.c
> index b971740fc2aa..cc53fa676706 100644
> --- a/arch/openrisc/kernel/ptrace.c
> +++ b/arch/openrisc/kernel/ptrace.c
> @@ -132,7 +132,6 @@ void ptrace_disable(struct task_struct *child)
>  	pr_debug("ptrace_disable(): TODO\n");
>  
>  	user_disable_single_step(child);
> -	clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
>  }
>  
>  long arch_ptrace(struct task_struct *child, long request, unsigned long addr,
> -- 
> 2.36.1
>