linux-kernel - Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a8a2b0d-fa7c-e8c6-bb04-152f8c17aa76@gmail.com>
Date:   Tue, 30 Aug 2022 09:37:18 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, kernel@...labora.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield
 header



On 29/08/2022 22:44, Nícolas F. R. A. Prado wrote:
> Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
> where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
> which are defined in the bitfield header. Add an explicit include for it
> so we're sure to have the symbols defined independently of the config.
> 
> Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros where possible")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 
> ---
> 
>   drivers/soc/mediatek/mtk-svs.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 64dba9f830f3..f67f3e971653 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -3,6 +3,7 @@
>    * Copyright (C) 2022 MediaTek Inc.
>    */
>   
> +#include <linux/bitfield.h>
>   #include <linux/bits.h>

What do we need the bits.h for?

Regards,
Matthias

>   #include <linux/clk.h>
>   #include <linux/completion.h>