linux-kernel - RE: [PATCH v1 0/2] Fix the wrong order of phy callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AS8PR04MB86763A2187AED57CFD55625E8C799@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date:   Tue, 30 Aug 2022 07:50:55 +0000
From:   Hongxing Zhu <hongxing.zhu@....com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        "kishon@...com" <kishon@...com>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v1 0/2] Fix the wrong order of phy callbacks

> -----Original Message-----
> From: Ahmad Fatoum <a.fatoum@...gutronix.de>
> Sent: 2022年8月30日 15:16
> To: Hongxing Zhu <hongxing.zhu@....com>; l.stach@...gutronix.de;
> bhelgaas@...gle.com; lorenzo.pieralisi@....com; vkoul@...nel.org; Marcel
> Ziswiler <marcel.ziswiler@...adex.com>; kishon@...com
> Cc: linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>; kernel@...gutronix.de; linux-phy@...ts.infradead.org;
> linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v1 0/2] Fix the wrong order of phy callbacks
> 
> Hello Richard,
> 
> On 30.08.22 05:47, Hongxing Zhu wrote:
> >>> [PATCH v1 1/2] PCI: imx6: Fix the wrong order of phy_init() and
> >>> [PATCH
> >>> v1 2/2] phy: freescale: imx8m-pcie: Fix the wrong order of
> >>
> >> This introduces an intermittent breakage. Can you squash?
> >
> > Hi Ahmad:
> > Thanks for your comments.
> > Do you mean to squash this fix to the preview series?
> > I'm afraid that it's not easy to do that.
> > Because there are a lot of pci-imx6 code changes after
> > commit: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> standalone phy driver").
> 
> The way I understand it, if a bisect ends up between your two patches, i.MX8M
> PCIe will be broken, whereas it worked before. I thus wonder if we shouldn't
> instead squash this series here into a single patch.
Yes, it's a possible case when do the bisect.
Since these changes are belong to different git repo.
It will bring maintain difficulties if these two patches are squashed into a
 single one.
It's difficult to make a choice.

Best Regards
Richard Zhu
> 
> Cheers,
> Ahmad
> 
> 
> >
> > Best Regards
> > Richard Zhu
> >>
> >>>
> >>>
> >>
> >>
> >> --
> >> Pengutronix e.K.                           |
> >> |
> >> Steuerwalder Str. 21                       |
> >> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> >>
> pe%2F&amp;data=05%7C01%7Chongxing.zhu%40nxp.com%7C9950124bc71c
> 4e8c3c6
> >>
> 708da8a577051%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 79744054
> >>
> 06906036%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi
> V2luMzIi
> >>
> LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=vKFXx
> 4XDjRsK
> >> Kqh9aBGOmDTNGnDJuUcJhOnTf7boCEw%3D&amp;reserved=0
> >>
> ngutronix.de%2F&amp;data=05%7C01%7Chongxing.zhu%40nxp.com%7C3277
> >>
> 61bac5b9407d977008da89886b15%7C686ea1d3bc2b4c6fa92cd99c5c30163
> >>
> 5%7C0%7C0%7C637973516254656985%7CUnknown%7CTWFpbGZsb3d8eyJ
> >>
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> >>
> C3000%7C%7C%7C&amp;sdata=hasOtX77%2Fea5yLbV8C7wOfdZStF5erHOL58
> >> Zf6ZZbo4%3D&amp;reserved=0  |
> >> 31137 Hildesheim, Germany                  | Phone:
> >> +49-5121-206917-0    |
> >> Amtsgericht Hildesheim, HRA 2686           | Fax:
> >> +49-5121-206917-5555 |
> 
> 
> --
> Pengutronix e.K.                           |
> |
> Steuerwalder Str. 21                       |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
> ngutronix.de%2F&amp;data=05%7C01%7Chongxing.zhu%40nxp.com%7C9950
> 124bc71c4e8c3c6708da8a577051%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C637974405406906036%7CUnknown%7CTWFpbGZsb3d8eyJW
> IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000%7C%7C%7C&amp;sdata=xWe0unt2cJs44zJf10h%2B3fsvxk6SuON6tDcACH
> owImA%3D&amp;reserved=0  |
> 31137 Hildesheim, Germany                  | Phone:
> +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:
> +49-5121-206917-5555 |