linux-kernel - Re: [PATCH] cpufreq: bmips-cpufreq: Use module_init and add module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <954cdab4-62d3-b413-f615-9c7b1563c1b1@huawei.com>
Date:   Tue, 30 Aug 2022 16:01:00 +0800
From:   "zhangjianhua (E)" <chris.zjh@...wei.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
CC:     <mmayer@...adcom.com>, <rafael@...nel.org>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: bmips-cpufreq: Use module_init and add
 module_exit


在 2022/8/30 13:29, Viresh Kumar 写道:
> On 26-08-22, 10:18, Zhang Jianhua wrote:
>> - Use module_init instead of device_initcall.
>> - Add a function for module_exit to unregister driver.
>>
>> Signed-off-by: Zhang Jianhua <chris.zjh@...wei.com>
>> ---
>>   drivers/cpufreq/bmips-cpufreq.c | 10 ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/bmips-cpufreq.c b/drivers/cpufreq/bmips-cpufreq.c
>> index f7c23fa468f0..21c0417c95e1 100644
>> --- a/drivers/cpufreq/bmips-cpufreq.c
>> +++ b/drivers/cpufreq/bmips-cpufreq.c
>> @@ -156,7 +156,7 @@ static struct cpufreq_driver bmips_cpufreq_driver = {
>>   	.name		= BMIPS_CPUFREQ_PREFIX,
>>   };
>>   
>> -static int __init bmips_cpufreq_probe(void)
>> +static int __init bmips_cpufreq_driver_init(void)
>>   {
>>   	struct cpufreq_compat *cc;
>>   	struct device_node *np;
>> @@ -176,7 +176,13 @@ static int __init bmips_cpufreq_probe(void)
>>   
>>   	return cpufreq_register_driver(&bmips_cpufreq_driver);
>>   }
>> -device_initcall(bmips_cpufreq_probe);
>> +module_init(bmips_cpufreq_driver_init);
>> +
>> +static void __exit bmips_cpufreq_driver_exit(void)
>> +{
>> +	cpufreq_unregister_driver(&bmips_cpufreq_driver);
>> +}
>> +module_exit(bmips_cpufreq_driver_exit)
> Semicolon ? Did you even compile this ? :)

Semicolon is not necessary for module_exit, and it can be compiled. I will send v2 patch to keep the format consistent, thanks.

>>   
>>   MODULE_AUTHOR("Markus Mayer <mmayer@...adcom.com>");
>>   MODULE_DESCRIPTION("CPUfreq driver for Broadcom BMIPS SoCs");
>> -- 
>> 2.31.0