linux-kernel - Re: [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e20dabe02d88f28fc933b596dee8b69d@kernel.org>
Date:   Tue, 30 Aug 2022 09:26:51 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     linus.walleij@...aro.org, bjorn.andersson@...aro.org,
        robimarko@...il.com, linux-arm-msm@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        johan+linaro@...nel.org, steev@...i.org
Subject: Re: [PATCH v2] pinctrl: qcom: spmi-gpio: Make IRQCHIP immutable

On 2022-08-30 09:12, Manivannan Sadhasivam wrote:
> The IRQCHIP implementation used inside the gpiochips are not supposed 
> to

lower case

> be changed during runtime. So let's make the one inside the spmi-gpio
> gpiochip immutable.
> 
> This fixes the below warning during boot:
> gpio gpiochip0: (c440000.spmi:pmic@0:gpio@...0): not an immutable
> chip, please consider fixing it!
> 
> Separate callbacks need to be provided for irq_{mask/unmask} pointers 
> since
> the callbacks are supposed to mask/unmask the corresponding parent IRQ 
> in
> addition to changing the gpio_desc flags.

This is all part of the existing documentation, so I don't think
this is really needed.

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

With the above fixed:

Acked-by: Marc Zyngier <maz@...nel.org>

         M.
-- 
Jazz is not dead. It just smells funny...