linux-kernel - Re: [PATCH] dt-bindings: mmc: renesas,sdhi: Add iommus property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8vJpj-S177DTsKezT=f3T4Oup0763fQtK3+9Rsums0N9Q@mail.gmail.com>
Date:   Tue, 30 Aug 2022 09:28:05 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Linux MMC List <linux-mmc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Biju Das <biju.das.jz@...renesas.com>
Subject: Re: [PATCH] dt-bindings: mmc: renesas,sdhi: Add iommus property

Hi Geert,

Thank you for the review.

On Tue, Aug 30, 2022 at 8:06 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> Thanks for your patch!
>
> On Mon, Aug 29, 2022 at 11:43 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> > The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU.
>
> blocks ... SoCs
>
> > This patch fixes the below dtbs_check warnings:
> > arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@...00000: Unevaluated properties are not allowed ('iommus' was unexpected)
> >         From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -77,6 +77,9 @@ properties:
> >
> >    clock-names: true
> >
> > +  iommus:
> > +    maxItems: 1
>
> I would insert iommus below dma-names, as iommus belongs to dmas,
> logically (yes I know dmas is not used on R-Car Gen3 and RZ/G2, as
> SDHI has its own DMA controller).
>
Ok, I will move it after dmas along with an updated commit message and
send a v2.

Cheers,
Prabhakar