linux-kernel - Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80280240-8769-ea25-6348-b5f60d34ef5f@gmail.com>
Date:   Tue, 30 Aug 2022 10:56:05 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     kernel@...labora.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield
 header



On 30/08/2022 10:06, AngeloGioacchino Del Regno wrote:
> Il 30/08/22 09:37, Matthias Brugger ha scritto:
>>
>>
>> On 29/08/2022 22:44, Nícolas F. R. A. Prado wrote:
>>> Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
>>> where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
>>> which are defined in the bitfield header. Add an explicit include for it
>>> so we're sure to have the symbols defined independently of the config.
>>>
>>> Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros 
>>> where possible")
>>> Reported-by: kernel test robot <lkp@...el.com>
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
>>>
>>> ---
>>>
>>>   drivers/soc/mediatek/mtk-svs.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
>>> index 64dba9f830f3..f67f3e971653 100644
>>> --- a/drivers/soc/mediatek/mtk-svs.c
>>> +++ b/drivers/soc/mediatek/mtk-svs.c
>>> @@ -3,6 +3,7 @@
>>>    * Copyright (C) 2022 MediaTek Inc.
>>>    */
>>> +#include <linux/bitfield.h>
>>>   #include <linux/bits.h>
>>
>> What do we need the bits.h for?
>>
> 
> bits.h has the definition for GENMASK(h, l), used in this file :-)
> 

Right, seems that some other include includes bits.h as well, as compilation 
does not break. But we probably don't want to rely on that for the future.

Applied thanks.

> Cheers,
> Angelo
> 
>> Regards,
>> Matthias
>>
>>>   #include <linux/clk.h>
>>>   #include <linux/completion.h>
> 
>