linux-kernel - RE: [PATCH 1/4] firmware: xilinx: Add afi ioctl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB3993321B918B2124B6776320CD799@DM6PR12MB3993.namprd12.prod.outlook.com>
Date:   Tue, 30 Aug 2022 09:25:47 +0000
From:   "Manne, Nava kishore" <nava.kishore.manne@....com>
To:     Xu Yilun <yilun.xu@...el.com>
CC:     "git (AMD-Xilinx)" <git@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "hao.wu@...el.com" <hao.wu@...el.com>,
        "trix@...hat.com" <trix@...hat.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "ronak.jain@...inx.com" <ronak.jain@...inx.com>,
        "rajan.vaja@...inx.com" <rajan.vaja@...inx.com>,
        "abhyuday.godhasara@...inx.com" <abhyuday.godhasara@...inx.com>,
        "piyush.mehta@...inx.com" <piyush.mehta@...inx.com>,
        "lakshmi.sai.krishna.potthuri@...inx.com" 
        <lakshmi.sai.krishna.potthuri@...inx.com>,
        "harsha.harsha@...inx.com" <harsha.harsha@...inx.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "nava.manne@...inx.com" <nava.manne@...inx.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>
Subject: RE: [PATCH 1/4] firmware: xilinx: Add afi ioctl support

Hi Yilun,

	Please find my response inline. 

> -----Original Message-----
> From: Xu Yilun <yilun.xu@...el.com>
> Sent: Saturday, August 27, 2022 11:52 AM
> To: Manne, Nava kishore <nava.kishore.manne@....com>
> Cc: git (AMD-Xilinx) <git@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; michal.simek@...inx.com;
> mdf@...nel.org; hao.wu@...el.com; trix@...hat.com;
> p.zabel@...gutronix.de; gregkh@...uxfoundation.org;
> ronak.jain@...inx.com; rajan.vaja@...inx.com;
> abhyuday.godhasara@...inx.com; piyush.mehta@...inx.com;
> lakshmi.sai.krishna.potthuri@...inx.com; harsha.harsha@...inx.com;
> linus.walleij@...aro.org; nava.manne@...inx.com;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; linux-fpga@...r.kernel.org; yilun.xu@...el.com
> Subject: Re: [PATCH 1/4] firmware: xilinx: Add afi ioctl support
> 
> On 2022-08-24 at 09:25:39 +0530, Nava kishore Manne wrote:
> > Adds afi ioctl to support dynamic PS-PL bus width settings.
> 
> Please also describe what is afi, PS, PL here, Patch #0 won't appear in
> upstream tree finally.
> 

Agree, Will update the description in v2.

> Thanks,
> Yilun
> 
> >
> > Signed-off-by: Nava kishore Manne <nava.kishore.manne@....com>
> > ---
> >  drivers/firmware/xilinx/zynqmp.c     | 14 +++++++++++
> >  include/linux/firmware/xlnx-zynqmp.h | 36
> > ++++++++++++++++++++++++++++
> >  2 files changed, 50 insertions(+)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c
> > b/drivers/firmware/xilinx/zynqmp.c
> > index d1f652802181..cbd84c96a66a 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -843,6 +843,20 @@ int zynqmp_pm_read_pggs(u32 index, u32
> *value)  }
> > EXPORT_SYMBOL_GPL(zynqmp_pm_read_pggs);
> >
> > +/**
> > + * zynqmp_pm_afi() - PM API for setting the PS-PL bus width
> > + * @config_id:	Register index value
> > + * @bus_width:	Afi interface bus width value.
> > + *
> > + * Return:	Returns status, either success or error+reason
> 
> I see other functions are also like this, but I still can't figure out what values
> for success and what for error+reason.
> 

Please find the relevant error info here:
https://elixir.bootlin.com/linux/v6.0-rc3/source/drivers/firmware/xilinx/zynqmp.c#L81

Regards,
Navakishore.