linux-kernel - [PATCH] spi: amd: Fix speed selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 15:06:07 +0530
From:   Shreeya Patel <shreeya.patel@...labora.com>
To:     broonie@...nel.org, sanju.mehta@....com
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com, krisman@...labora.com,
        alvaro.soliverez@...labora.com,
        Shreeya Patel <shreeya.patel@...labora.com>
Subject: [PATCH] spi: amd: Fix speed selection

If the current speed is equal to the requested speed by the device
then return success.
This patch fixes a bug introduced by the commit 3fe26121dc3a
("spi: amd: Configure device speed") which checks speed_hz instead
of amd_spi->speed_hz.

Fixes: 3fe26121dc3a ("spi: amd: Configure device speed")
Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com>
---
 drivers/spi/spi-amd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/spi/spi-amd.c b/drivers/spi/spi-amd.c
index 264633c5ce0b..e23121456c70 100644
--- a/drivers/spi/spi-amd.c
+++ b/drivers/spi/spi-amd.c
@@ -240,9 +240,6 @@ static int amd_set_spi_freq(struct amd_spi *amd_spi, u32 speed_hz)
 {
 	unsigned int i, spd7_val, alt_spd;
 
-	if (speed_hz == amd_spi->speed_hz)
-		return 0;
-
 	if (speed_hz < AMD_SPI_MIN_HZ)
 		return -EINVAL;
 
@@ -250,7 +247,7 @@ static int amd_set_spi_freq(struct amd_spi *amd_spi, u32 speed_hz)
 		if (speed_hz >= amd_spi_freq[i].speed_hz)
 			break;
 
-	if (speed_hz == amd_spi_freq[i].speed_hz)
+	if (amd_spi->speed_hz == amd_spi_freq[i].speed_hz)
 		return 0;
 
 	amd_spi->speed_hz = amd_spi_freq[i].speed_hz;
-- 
2.30.2