linux-kernel - RE: [PATCH V2] Input: synaptics-rmi4 - filter incomplete relative packet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR03MB5848C74BD8C8FA9CB07C8C8DA3799@PH0PR03MB5848.namprd03.prod.outlook.com>
Date:   Tue, 30 Aug 2022 09:59:26 +0000
From:   Marge Yang <Marge.Yang@...synaptics.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        margeyang <marge.yang@...aptics.corp-partner.google.com>,
        Wayne Chang <wayne.chang@...synaptics.com>
CC:     "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
        Kevin Chu <kevin.chu@...synaptics.com>,
        Derek Cheng <derek.cheng@...synaptics.com>,
        Vincent Huang <Vincent.huang@...synaptics.com>,
        Carl Yang <Carl.Yang@...aptics.com>,
        Ian Lu <Ian.Lu@...synaptics.com>,
        Darren Kang <Darren.Kang@...synaptics.com>
Subject: RE: [PATCH V2] Input: synaptics-rmi4 - filter incomplete relative
 packet.

Hi Dmitry,
	May I know if you have any concerns about FW's feedback? 

Thanks
Marge Yang

-----Original Message-----
From: Marge Yang 
Sent: Monday, August 15, 2022 2:50 PM
To: Dmitry Torokhov <dmitry.torokhov@...il.com>; margeyang <marge.yang@...aptics.corp-partner.google.com>; Wayne Chang <wayne.chang@...synaptics.com>; Marge Yang <Marge.Yang@...synaptics.com>
Cc: linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; hdegoede@...hat.com; benjamin.tissoires@...hat.com; Kevin Chu <kevin.chu@...synaptics.com>; Derek Cheng <derek.cheng@...synaptics.com>; Vincent Huang <Vincent.huang@...synaptics.com>; Carl Yang <Carl.Yang@...aptics.com>; Ian Lu <Ian.Lu@...synaptics.com>; Darren Kang <Darren.Kang@...synaptics.com>
Subject: RE: [PATCH V2] Input: synaptics-rmi4 - filter incomplete relative packet.

Add Synaptics firmware member

Hi Dmitry,
	Update Synaptics firmware's comment.
[Wayne 08/15]
To address the transaction error case in the middle would potential lead to the unexpected data transaction and latency between styk device and host driver.  F$03 didn't really parse any data packet but simply works as bridge functionality to bypass the command and response packets between styk device and driver.

Thanks
Marge Yang

-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
Sent: Saturday, August 13, 2022 3:28 AM
To: margeyang <marge.yang@...aptics.corp-partner.google.com>
Cc: linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; hdegoede@...hat.com; benjamin.tissoires@...hat.com; Marge Yang <Marge.Yang@...synaptics.com>; Derek Cheng <derek.cheng@...synaptics.com>; Vincent Huang <Vincent.huang@...synaptics.com>
Subject: Re: [PATCH V2] Input: synaptics-rmi4 - filter incomplete relative packet.

CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe.


Hi Marge,

On Fri, Aug 12, 2022 at 04:43:25PM +0800, margeyang wrote:
> From: Marge Yang <marge.yang@...aptics.corp-partner.google.com>
>
> RMI4 F03 supports the Stick function,
> it's designed to support relative packet.
> This patch supports the following case.
> When relative packet can't be reported completely, it may miss one 
> byte or two byte.
> New Synaptics firmware will report PARITY error.
> When timeout error or parity error happens,
> RMI4 driver will sends 0xFE command and ask FW to Re-send stick packet 
> again.

My understanding is that F03 is intended to be a pass-through mechanism for PS/2-compatible devices. In that spirit all protocol handling and validation should happen in psmouse driver that attaches to a serio port provided by F03.

Historically we did not pay attention to parity and frame errors for
PS/2 mice/touchpads (and for keyboards on x86) but we coudl add such code there. Do we actually observe this with RMI devices? Can RMI firmware handle this better instead?

Thanks.

--
Dmitry