linux-kernel - Re: [PATCH v9 05/10] lib: add linear range index macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a97be2ae-b7d2-2ecf-fa17-de2d8755fb83@gmail.com>
Date:   Tue, 30 Aug 2022 13:22:13 +0300
From:   Matti Vaittinen <mazziesaccount@...il.com>
To:     ChiaEn Wu <peterwu.pub@...il.com>, lee@...nel.org,
        daniel.thompson@...aro.org, jingoohan1@...il.com, pavel@....cz,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        matthias.bgg@...il.com, sre@...nel.org, jic23@...nel.org,
        lars@...afoo.de, deller@....de, broonie@...nel.org,
        andriy.shevchenko@...ux.intel.com
Cc:     chiaen_wu@...htek.com, alice_chen@...htek.com,
        cy_huang@...htek.com, dri-devel@...ts.freedesktop.org,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-fbdev@...r.kernel.org, szunichen@...il.com,
        andy.shevchenko@...il.com
Subject: Re: [PATCH v9 05/10] lib: add linear range index macro

On 8/30/22 06:40, ChiaEn Wu wrote:
> From: ChiaEn Wu <chiaen_wu@...htek.com>
> 
> Add linear_range_idx macro for declaring the linear_range struct simply.
> 
> Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>

Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

> ---
> 
> v9
> - Revise LINEAR_RANGE() and LINEAR_RANGE_IDX()
> ---
>   include/linux/linear_range.h | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/include/linux/linear_range.h b/include/linux/linear_range.h
> index fd3d0b3..2e4f4c3 100644
> --- a/include/linux/linear_range.h
> +++ b/include/linux/linear_range.h
> @@ -26,6 +26,17 @@ struct linear_range {
>   	unsigned int step;
>   };
>   
> +#define LINEAR_RANGE(_min, _min_sel, _max_sel, _step)		\
> +	{							\
> +		.min = _min,					\
> +		.min_sel = _min_sel,				\
> +		.max_sel = _max_sel,				\
> +		.step = _step,					\
> +	}
> +
> +#define LINEAR_RANGE_IDX(_idx, _min, _min_sel, _max_sel, _step)	\
> +	[_idx] = LINEAR_RANGE(_min, _min_sel, _max_sel, _step)
> +
>   unsigned int linear_range_values_in_range(const struct linear_range *r);
>   unsigned int linear_range_values_in_range_array(const struct linear_range *r,
>   						int ranges);


-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~